fix: Only remove packages by binary overlap #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ownership by file overlap would remove packages of the same type, or packages with an empty type. Instead, only remove packages by overlap if the owned package is binary, since the installation source of the binary will have better version info than the binary itself. Signed-off-by: Will Murphy <[email protected]>
wagoodman
approved these changes
Aug 18, 2023
wagoodman
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ownership by file overlap would remove packages of the same type, or packages with an empty type. Instead, only remove packages by overlap if the owned package is binary, since the installation source of the binary will have better version info than the binary itself.